Move custom translation strings to its own file #775
Conversation
|
This is still a work in progress. Got some more testing and changes I want to do, but in my initial testing, this seems to fix the problem. |
|
Deploy preview for docusaurus-preview ready! Built with commit ab1ca99 |
|
Deploy preview for docusaurus-preview ready! Built with commit efc6f06 |
|
Given that we already have a data directory for custom information (e.g. site users), I think defaulting to that directory is reasonable. If we get pushback for a custom Seem reasonable?
Absolutely! Just making sure this is the right direction. 😄 |
|
Seems reasonable for me. Let's not bloat LGTM. Seems to be in the right direction |
|
@endiliey Docs - https://deploy-preview-775--docusaurus-preview.netlify.com/docs/en/next/translation#custom-translation-strings I am just going to show a test plan, then I will remove the [RFC] from this and get it officially reviewed and merged. |
|
Looks awesome! Thanks for fixing :) |
|
@JoelMarcey This looks awesome to me 👍 |
JoelMarcey
changed the title
|
Added a test plan. This should be ready for review and merging. |
JoelMarcey
added
the
proposal
Motivation
Allowing custom and overriding translation strings in
en.jsoncaused us to not deleteen.jsonlike we used to do and thus would not allow updates to header to be reflected any longer.Fixes #713
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Local testing
Related PRs
#158
#710